[linux-tr] Re: Buffer overrun in /proc/net/tr_rif

[Adrian Bridgett <bridgett@hursley.ibm.com>]

On Thu, Apr 08, 1999 at 08:11:49AM +0100, Adrian Bridgett wrote:
> cat /proc/net/tr_rif can result in buffer overruns.
> 
> Admittedly I only observed this when running my cleaned-up version, but I
> think it will still occur in the normal case.
> 
> This is the patch I was using - the line numbers probably won't line up
> since I've just cut Paul's big-RIF patch out of it.
> @@ -498,8 +496,6 @@
>  			if(pos>offset+length)
>  				break;
>  	   	}
> -		if(pos>offset+length)
> -			break;
>  	}
>  
>  	*start=buffer+(offset-begin); /* Start of wanted data */


Oops - the bad part of my patch. The main code is fine.

Cheers

Adrian

Adrian Bridgett <bridgett@hursley.ibm.com>
Internal: 7-245528  External: 01962-815528